Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-dupe dex client configuration, assign dex secret #180

Closed
richard-cox opened this issue Jan 25, 2023 · 1 comment
Closed

De-dupe dex client configuration, assign dex secret #180

richard-cox opened this issue Jan 25, 2023 · 1 comment
Assignees
Labels

Comments

@richard-cox
Copy link
Member

richard-cox commented Jan 25, 2023

Dex integration was added by #167.

This includes the ability to disable dex and also provide a secure dex client key. However this has led two issues

Helm dex configuration is duplicated

The epinio chart values now contains duplicate sections for dex and epinio-ui: dex (see below for example)

Dex client secret

The dex client contains a secret that is used in it's chart template. This same value must also be used in the epinio-ui chart. This is currently duplicated, but should change to use a kube secret anyway

Example epinio values.yaml

global:
  domain: '<snip>'
dex:
  enabled: true
  ui:
    secret: 'dev-secret1'
epinio-ui:
  epinioUI:
    apiSkipSSL: true
  dex:
    enabled: true
    ui:
      secret: "dev-secret1"
@richard-cox richard-cox self-assigned this Jan 25, 2023
richard-cox added a commit to richard-cox/helm-charts that referenced this issue Jan 25, 2023
richard-cox added a commit to richard-cox/helm-charts that referenced this issue Jan 25, 2023
@richard-cox
Copy link
Member Author

richard-cox commented Jan 25, 2023

I've moved dex.enabled out to global.dex.enabled in order for sub chart to make use of it.

I've also used a kube secret for the dex ui client secret

epinio/helm-charts@c4cf206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Status: Done
Development

No branches or pull requests

1 participant