-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Improved Logging #466
Draft
jonrandahl
wants to merge
27
commits into
dev
Choose a base branch
from
hotfix/reduce-log-noise
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Candidate: v1.7.3
Release v1.7.3
refactored v1.7.4 tag date to reflect latest changes
Error 500 internal server error when trying to print data table
Release v1.7.4
Task: Release Candidate v 1.7.5
Release v1.7.5 to Preprod
Release v1.7.5 to Production
also updated method call in exceptions initialiser
Set the Internal Error Instrumentation to an `unless` statement to ensure the application does not report internal errors to the Prometheus metrics when the error is a 404 thereby reducing the noise in the Slack alerts channel
Split the error logging into it's own method as well as adjusted the logged message to be either the response message or the response status
from 1.7.5 ~> 1.7.6
for debugging rails applications in the browser: https://chromewebstore.google.com/detail/rails-panel/gjpfobpafnhjhbajcjgccbbdofdckggg?pli=1
not microseconds
also includes minor empty line updates
also cleaned up the outdated comments for the plugin
to ensure the metric is only triggered on errors with a 500 status or greater
now using hash approach to ensure specific logging fields are included in messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.