Primarily Prometheus Metrics #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `CountAsOne: ['array', 'hash', 'heredoc', 'method_call']` to `Metrics/ClassLength` and `Metrics/MethodLength`; also includes files changed by rules, primarily removing erroneous inline disabling commands
updated to include the metrics for filtering and sorting in the metrics dashboard as needed
mirrored makefiles from the other HMLR applications to ensure expected targets exist
Notify subscriber(s) of an internal error event with the payload of the exception once done
expose additional metrics for the puma server
adds templated error pages to mirror other applications as well as controls 404 errors to be ignored in the `instrument_internal_error` metric
v1.5.3 ~> 1.5.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focussing primarily on ticket #148 for the addition of Prometheus metrics endpoint to the application, additional changes for error control, usability, and functionality have been interspersed.
Included changes
process_threadsgauge to prometheus metrics alongside isolating thread counts to specific status' as per the Rails thread documentation GH-148puma-metricsgem to provide base metrics for the Puma web serverinternal_error_eventmetric to the improved error controlsAdditional changes
puma.statsto footer template in development environment only, again as per the approach in theLR_Common_StylesgemCountAsOneto bothMetrics/ClassLengthandMetrics/MethodLength; includes files with removed earlier disabling of said rules!.gitignoreto include ignoringbyebughistory as well as sets the tmp directory ignore to be anywhere, not just at the project root