adds underline text to standard reports landing page #121
Conversation
| @@ -1,5 +1,4 @@ | |||
| .o-help-link | |||
| = link_to "https://www.gov.uk/guidance/price-paid-data-standard-reports#guidance-on-searching-the-data", class: "button button--secondary", alt: "Help and tips", title: "Help and tips" do | |||
| %i.fa.fa-question-circle | |||
| help | |||
|
|
|||
| help | |||
There was a problem hiding this comment.
Github complaining about the lack of new line at the end of this file, otherwise it looks good to me 👍
Please wait to merge!Once the updated Common Styles gem has been released into the package repository, we will need to update the gemfile to use the "new" gem version otherwise Rails won't install the updated gem. line 83 will need to read: gem 'lr_common_styles', '~> 1.9', '>= 1.9.4' |
|
@jonrandahl Should we make a note/create a ticket to update the gem file when we are ready to go to pre-prod with the current changes and just keep updating the dev branch for this repo for now? |
Yes and no... Yes, because the changes contained within this PR will be applied to the specific SR UI updates contained and therefore verifiable; however, the application will be missing the changes contained in the updated styles gem. Which leads us to the No, because this will require another release of each of the applications to include this new gem version. If we choose to release often, which is a good thing, should we still increment the version cadence as a patch simply for the associated gem update? |
Please see this ticket #114
