Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Prometheus Metrics - Update #138

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

jonrandahl
Copy link
Contributor

This PR encloses all changes from ticket #135 to ensure the prometheus metrics are updated and implemented in accordance with the proposed approach contained within the Internal Wiki

… info

Implements default metrics port number to enable running multiple sibling HMLR apps locally if needed

N.B.  Commented out until ruby is updated to 2.7 or greater to allow the use of the puma-metrics plugin as we're using puma 6.0.0 or greater
Adds `Middleware instrumentation` fix for 0 memory bug by notifying Action Dispatch subscribers on Prometheus initialise
…ber.rb`

Adds `Metrics/MethodLength` ignore rule for rubocop
!IMPORTANT: This method is not used in the codebase and is only here for reference
…file

Loads all the notification subscribers in the application so that they are registered
@jonrandahl jonrandahl self-assigned this Sep 17, 2024
Copy link
Contributor

@bogdanadrianmarc bogdanadrianmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonrandahl jonrandahl merged commit f35330c into dev Sep 18, 2024
2 checks passed
@jonrandahl jonrandahl deleted the issue/135-task-prometheus-metrics-update branch September 18, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants