Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA specs #22

Merged
merged 12 commits into from
Feb 23, 2022
Merged

QA specs #22

merged 12 commits into from
Feb 23, 2022

Conversation

mairead
Copy link

@mairead mairead commented Nov 18, 2021

Includes Gauge Markdown test specs for the following applications:

  • landing
  • PPD
  • UKHPI
  • Standard reports

NB: does not include any test specs for the SPARQL query console as deemed out of scope

specs/ppd-search.spec Outdated Show resolved Hide resolved
specs/ppd-search.spec Outdated Show resolved Hide resolved
Tags: Search

* Type "Birmingham" into the "Town or city" field
* Select 'all' from the 'How many results?' radio list
Copy link
Contributor

@ijdickinson ijdickinson Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is exactly the kind of query where we'd like to have eyes-on the memory usage of the app as it's running

@ijdickinson
Copy link
Contributor

I've only reviewed the ppd-search.spec so far, but this looks good!

specs/ppd-results.spec Outdated Show resolved Hide resolved

Tags: data, results

* Default query is set to 'United Kingdom' and 'October 2020 to October 2021'
Copy link
Contributor

@ijdickinson ijdickinson Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the default will be "to" the latest month for which data is available, "from" 12 months prior to that. So it will change depending on when the most recent publication was. The "to:" date should, however, never be more than 2 months ago.

@ijdickinson
Copy link
Contributor

Looking really good so far! 👍

Copy link

@bogdanadrianmarc bogdanadrianmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as my understanding of this goes, it looks good to me 👍

Copy link
Contributor

@ijdickinson ijdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ... great job! 👍

I made a couple of small suggestions inline. Two other things we might want to add to the PPD tests (based on remembered pain!):

  • test that the text indexer does not remove stop words by searching for a street named "The Street". For example, a search for "The Street" in Brighton should return fewer than 100 results, all with the street name "The Street"
  • Non-removal of apostrophes: a search for "King's" in Birmingham should return one result (King's Court), whereas a search for "kings" returns many results

* Click button to advance to 'Next' screen
* Repeat step 6
* Click 'Generate report' button
* Whilst generating the User will see 'in progress, estimated complete in' with a given timeframe.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a nuance here. If you select a set of parameters for which a standard report has been previously generated, the result will be served from S3 cache. So instead of position in the queue or "in progress", you will go straight to the download links.

These cached reports are cleared once per month when the source data is updated.

* Navigation items will be displayed in Welsh language
* Clicking main navigation title will route user back to home page and language will default to English
* Click English link in top right
* All Displayed text will change to English language
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the possible exception of some place names, which don't have Welsh-language equivalents

@joescottdave
Copy link

Not familiar with this sort of thing. Are these then rendered interactive somehow, so that a person can tick boxes as they run through them or is that a purely manual process?

@joescottdave
Copy link

Can we merge this in, @ijdickinson ?

@ijdickinson
Copy link
Contributor

Can we merge this in, @ijdickinson ?

Sure, gfi

@joescottdave joescottdave merged commit 65df9e4 into dev Feb 23, 2022
@joescottdave joescottdave deleted the qa-specs branch February 23, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants