From ce66232eb4318435bebc7a6527805166d1828b1a Mon Sep 17 00:00:00 2001
From: nikosbosse <nikosbosse@gmail.com>
Date: Thu, 31 Oct 2024 15:21:36 +0100
Subject: [PATCH 1/3] remove mentions of the getting started vignette which
 doesn't exist anymore

---
 R/score.R    | 10 +++-------
 README.Rmd   |  4 +++-
 man/score.Rd |  4 ++--
 3 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/R/score.R b/R/score.R
index da19c515..7d92f9af 100644
--- a/R/score.R
+++ b/R/score.R
@@ -10,9 +10,8 @@
 #' See [get_forecast_unit()] for more information on the concept of a forecast
 #' unit.
 #'
-#' For additional help and examples, check out the [Getting Started
-#' Vignette](https://epiforecasts.io/scoringutils/articles/scoringutils.html) as
-#' well as the paper [Evaluating Forecasts with scoringutils in
+#' For additional help and examples, check out the paper
+#' [Evaluating Forecasts with scoringutils in
 #' R](https://arxiv.org/abs/2205.07090).
 #' @param forecast A forecast object (a validated data.table with predicted and
 #'   observed values).
@@ -100,13 +99,10 @@ score <- function(forecast, metrics, ...) {
 #' @export
 score.default <- function(forecast, metrics, ...) {
   cli_abort(
-    #nolint start: keyword_quote_linter
     c(
       "!" = "The input needs to be a valid forecast object.",
-      "i" = "Please convert to `forecast` object first by calling the
-      appropriate {.fn as_forecast_<type>} function)."
+      "i" = "Please convert to `forecast` object first (see {.fn as_forecast})." # nolint
     )
-    #nolint end
   )
 }
 
diff --git a/README.Rmd b/README.Rmd
index 859d91a5..5c628dff 100644
--- a/README.Rmd
+++ b/README.Rmd
@@ -56,7 +56,9 @@ The `scoringutils` package facilitates the process of evaluating forecasts in R,
 
 The package underwent a major re-write. The most comprehensive documentation for the updated package is the [revised version](https://drive.google.com/file/d/1URaMsXmHJ1twpLpMl1sl2HW4lPuUycoj/view?usp=drive_link) of our [original](https://doi.org/10.48550/arXiv.2205.07090) `scoringutils` paper. 
 
-Another good starting point are the vignettes on [Getting started](https://epiforecasts.io/scoringutils/articles/scoringutils.html), [Details on the metrics implemented](https://epiforecasts.io/scoringutils/articles/metric-details.html) and [Scoring forecasts directly](https://epiforecasts.io/scoringutils/articles/scoring-forecasts-directly.html).
+Another good starting point are the vignettes
+<!-- vignettes on [Getting started](https://epiforecasts.io/scoringutils/articles/scoringutils.html),  -->
+[Details on the metrics implemented](https://epiforecasts.io/scoringutils/articles/metric-details.html) and [Scoring forecasts directly](https://epiforecasts.io/scoringutils/articles/scoring-forecasts-directly.html).
 
 <!-- > Nikos I. Bosse, Hugo Gruson, Anne Cori, Edwin van Leeuwen, Sebastian Funk and Sam Abbott (2022). _`Evaluating Forecasts with scoringutils in R`_. arXiv:2205.07090 <https://doi.org/10.48550/arXiv.2205.07090> -->
 
diff --git a/man/score.Rd b/man/score.Rd
index 97ea5e3f..13a6b811 100644
--- a/man/score.Rd
+++ b/man/score.Rd
@@ -56,8 +56,8 @@ how to create a forecast object.
 See \code{\link[=get_forecast_unit]{get_forecast_unit()}} for more information on the concept of a forecast
 unit.
 
-For additional help and examples, check out the \href{https://epiforecasts.io/scoringutils/articles/scoringutils.html}{Getting Started Vignette} as
-well as the paper \href{https://arxiv.org/abs/2205.07090}{Evaluating Forecasts with scoringutils in R}.
+For additional help and examples, check out the paper
+\href{https://arxiv.org/abs/2205.07090}{Evaluating Forecasts with scoringutils in R}.
 }
 \details{
 \strong{Customising metrics}

From 64adb544347db5b1c89f8f6487e908d2b10fae6d Mon Sep 17 00:00:00 2001
From: nikosbosse <nikosbosse@gmail.com>
Date: Thu, 31 Oct 2024 15:24:12 +0100
Subject: [PATCH 2/3] re-apply existing fix

---
 R/score.R | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/R/score.R b/R/score.R
index 7d92f9af..0a1989cf 100644
--- a/R/score.R
+++ b/R/score.R
@@ -99,10 +99,13 @@ score <- function(forecast, metrics, ...) {
 #' @export
 score.default <- function(forecast, metrics, ...) {
   cli_abort(
+    #nolint start: keyword_quote_linter
     c(
       "!" = "The input needs to be a valid forecast object.",
-      "i" = "Please convert to `forecast` object first (see {.fn as_forecast})." # nolint
+      "i" = "Please convert to a `forecast` object first by calling the
+      appropriate {.fn as_forecast_<type>} function)."
     )
+    #nolint end
   )
 }
 

From ac6a5a0c37b743cc1cc2127565943f3a7e7d04a1 Mon Sep 17 00:00:00 2001
From: nikosbosse <nikosbosse@gmail.com>
Date: Thu, 31 Oct 2024 15:28:50 +0100
Subject: [PATCH 3/3] fix list in readme

---
 README.Rmd | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.Rmd b/README.Rmd
index 5c628dff..8e829bcd 100644
--- a/README.Rmd
+++ b/README.Rmd
@@ -85,6 +85,7 @@ remotes::install_github("epiforecasts/scoringutils", dependencies = TRUE)
 ### Forecast types
 
 `scoringutils` currently supports scoring the following forecast types: 
+
 - `binary`: a probability for a binary (yes/no) outcome variable.
 - `point`: a forecast for a continuous or discrete outcome variable that is represented by a single number.
 - `quantile`: a probabilistic forecast for a continuous or discrete outcome variable, with the forecast distribution represented by a set of predictive quantiles.