as_forecast_sample() manipulates the object if sample_id is given

[sbfnk]

Should this manipulate a copy instead? I suspect this is not behaviour people would necessarily expect.

library("scoringutils")
#> scoringutils 2.0.0 introduces major changes. We'd love your feedback!
#> <https://github.com/epiforecasts/scoringutils/issues>. To use the old version,
#> run: `remotes::install_github('epiforecasts/[email protected]')`
#> This message is displayed once per session.

set.seed(1234)

samples <- 10
value <- 5
example <- data.frame(
  observed = value,
  predicted = rnorm(samples, value, 1),
  sample = seq_len(samples)
)

scored <- suppressWarnings(
  score(as_forecast_sample(example, sample_id = "sample"))
)

colnames(example)
#> [1] "observed"  "predicted" "sample_id"

^{Created on 2024-11-02 with reprex v2.1.1}