Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink score() and maybe make it not S3 anymore #941

Open
nikosbosse opened this issue Oct 6, 2024 · 2 comments
Open

Rethink score() and maybe make it not S3 anymore #941

nikosbosse opened this issue Oct 6, 2024 · 2 comments
Labels
refactor Code refactoring
Milestone
scoringutils-2.x

Comments

@nikosbosse
Copy link
Contributor

From Sam's review on #940:

image
@nikosbosse nikosbosse added the refactor Code refactoring label Oct 6, 2024
@nikosbosse nikosbosse added this to the scoringutils-2.x milestone Oct 6, 2024
@nikosbosse nikosbosse mentioned this issue Oct 6, 2024
Merged
9 tasks
@seabbs
Copy link
Contributor

seabbs commented Oct 7, 2024

As I said in the comment I think this could be a good idea and potentially streamline the package. Happy to hear push back

@nikosbosse
Copy link
Contributor Author

Haven't thought it through fully, but so far your suggestion sounds great to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code refactoring
Projects
scoringutils 2.1
Status: No status
Milestone
scoringutils-2.x
Development

No branches or pull requests
2 participants
@seabbs @nikosbosse