Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up linter statements around cli conditions #807

Open
nikosbosse opened this issue May 5, 2024 · 0 comments
Open

Clean up linter statements around cli conditions #807

nikosbosse opened this issue May 5, 2024 · 0 comments
Labels
good first issue Good for newcomers implementation-ready This is ready for implementation

Comments

@nikosbosse
Copy link
Contributor

As suggested by Hugo, we should clean the linter statements surrounding cli.

The syntax to disable a specific linter is quite fussy and requires a period at the end. The current comment disables all linter.
The simplest option is probably to follow what this linter is suggesting in all cases:

      #nolint start: keyword_quote_linter
      cli_abort(
        c(
          `!` = "If a column 'scale' is present, entries with scale =='natural'
          are required for the transformation."
        )
      )

Originally posted by @Bisaloo in #791 (comment)

@nikosbosse nikosbosse added good first issue Good for newcomers implementation-ready This is ready for implementation labels May 27, 2024
@nikosbosse nikosbosse added this to the scoringutils-2.x milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers implementation-ready This is ready for implementation
Projects
Status: No status
Development

No branches or pull requests

1 participant