Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify add_pairwise_comparison to omit the need to have a stored attribute with unsummarised scores #400

Closed
Tracked by #517
nikosbosse opened this issue Nov 10, 2023 · 0 comments · Fixed by #633
Closed
Tracked by #517

Simplify add_pairwise_comparison to omit the need to have a stored attribute with unsummarised scores #400

nikosbosse opened this issue Nov 10, 2023 · 0 comments · Fixed by #633
Labels
Breaking change This issue discusses or suggests a potentially breaking change implementation-ready This is ready for implementation package improvement
Milestone
scoringutils-2.0

Comments

@nikosbosse
Copy link
Contributor

Both functions currently operate on a data.frame of unsummarised scores. If we restricted the order such that you'd always have to call them before summarise_scores() then we could get rid of the attribute of unsummarised scores that we're currently carrying around.
@nikosbosse nikosbosse converted this from a draft issue Nov 10, 2023
@nikosbosse nikosbosse added this to the scoringutils 2.0.0 milestone Nov 10, 2023
@nikosbosse nikosbosse changed the title Think about simplifying add_coverage and add_pairwise_comparison Simplify add_pairwise_comparison to omit the need to have a stored attribute with unsummarised scores Nov 15, 2023
@nikosbosse nikosbosse mentioned this issue Nov 18, 2023
Closed
@nikosbosse nikosbosse added the Breaking change This issue discusses or suggests a potentially breaking change label Nov 29, 2023
@nikosbosse nikosbosse mentioned this issue Nov 29, 2023
Closed
4 tasks
@nikosbosse nikosbosse added the implementation-ready This is ready for implementation label Dec 5, 2023
@nikosbosse nikosbosse mentioned this issue Dec 14, 2023
Closed
@nikosbosse nikosbosse mentioned this issue Feb 19, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change This issue discusses or suggests a potentially breaking change implementation-ready This is ready for implementation package improvement
Projects
scoringutils 2.0
Status: Done
Milestone
scoringutils-2.0
Development

Successfully merging a pull request may close this issue.

Issue #400: Simplify add_pairwise_comparison() epiforecasts/scoringutils
1 participant
@nikosbosse