Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review scoringutils 2.0.0 #373

Closed
nikosbosse opened this issue Oct 30, 2023 · 8 comments
Closed

Review scoringutils 2.0.0 #373

nikosbosse opened this issue Oct 30, 2023 · 8 comments

Comments

@nikosbosse
Copy link
Contributor

nikosbosse commented Oct 30, 2023

Once the major update that's currently in progress is done it would be great to have another package review like the ones done in #121 and #179.
@Bisaloo would you be up for another review once the update is finished?

@nikosbosse nikosbosse converted this from a draft issue Oct 30, 2023
@Bisaloo
Copy link
Member

Bisaloo commented Oct 30, 2023

Hi @nikosbosse, yes, I can do this 👍

@nikosbosse nikosbosse added blocked Something needs to happen before this can proceed and removed next-release labels Nov 18, 2023
@seabbs
Copy link
Contributor

seabbs commented Feb 28, 2024

I think we are getting close to this being done. Should we set a date for this that works for everyone?

@seabbs
Copy link
Contributor

seabbs commented Apr 9, 2024

Hi all. We are really very close to this now! @jamesmbaazam @Bisaloo would you have time you do this in the next few weeks? As a reminder the idea is to use the Ropensci review template and do a pseudo submission review. Ideally issues would be split into really needs to be done now and scored with some kind of urgency (so we can slot them into future releases in a way that makes sense and doesn't drive Nikos to post too many memes).

@seabbs seabbs removed the blocked Something needs to happen before this can proceed label Apr 12, 2024
@seabbs
Copy link
Contributor

seabbs commented Apr 12, 2024

Ping!!

@Bisaloo
Copy link
Member

Bisaloo commented Apr 12, 2024

I can do this over the next two weeks if that works for you.

@seabbs
Copy link
Contributor

seabbs commented Apr 12, 2024

That would be really great!

@seabbs
Copy link
Contributor

seabbs commented Apr 12, 2024

@Bisaloo
Copy link
Member

Bisaloo commented Apr 15, 2024

Can I follow the steps documented here: https://epiverse-trace.github.io/blueprints/code-review.html#full-package-review to open a PR with the full codebase as diff, so I can comment directly on specific portions of the code using GitHub PR review infrastructure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants