Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing #196

Closed
Tracked by #179
nikosbosse opened this issue Mar 5, 2022 · 4 comments · Fixed by #217
Closed
Tracked by #179

Improve testing #196

nikosbosse opened this issue Mar 5, 2022 · 4 comments · Fixed by #217
Labels
help wanted Extra attention is needed package improvement

Comments

@nikosbosse
Copy link
Contributor

Test coverage should be improved.

Examples of functions to be tested:

  • permutation_test() - should be tested againsdt the permutationTest function from the surveillance package by Michael Höhle, Andrea Riebler and Michaela Paul.
@seabbs seabbs mentioned this issue Mar 24, 2022
Closed
@seabbs
Copy link
Contributor

seabbs commented Mar 24, 2022 •
edited
Loading

Testing gaps blocking this issue from being closed.

  • avail_forecasts
  • add_coverage
  • find_duplicates
  • Option checking in check_summary_params
  • correlation
  • bias
  • plot_correlation
  • All plot functions in plot.R excluding plot_predictions. These tests can be of the do not error type as a minimum with snapshotting being a nice idea.

@seabbs seabbs mentioned this issue Mar 24, 2022
Closed
17 tasks
@nikosbosse
Copy link
Contributor Author

Helpful here: the chkDots() function

@seabbs seabbs added the help wanted Extra attention is needed label Mar 25, 2022
@seabbs
Copy link
Contributor

seabbs commented Apr 14, 2022

Are there some bits of this that would be useful to have help with @nikosbosse? Happy to put a PR in adding some coverage?

@nikosbosse
Copy link
Contributor Author

All the bits! Would be very happy about a PR :)

@seabbs seabbs mentioned this issue Apr 28, 2022
Merged
@seabbs seabbs linked a pull request Apr 28, 2022 that will close this issue
Feature: Add example based testing #217
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed package improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Add example based testing epiforecasts/scoringutils
2 participants
@seabbs @nikosbosse