Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the documentation of weigh argument to interval_score() #172

Closed
mbojan opened this issue Jan 12, 2022 · 1 comment · Fixed by #166
Closed

Typo in the documentation of weigh argument to interval_score() #172

mbojan opened this issue Jan 12, 2022 · 1 comment · Fixed by #166

Comments

@mbojan
Copy link

mbojan commented Jan 12, 2022

I believe there is a typo in the documentation of interval_score() where it says

#' @param weigh if TRUE, weigh the score by alpha / 4, so it can be averaged

while the theory e.g. eqs (1) and (2) of

Bracher, J., Wolffram, D., Deuschel, J., Görgen, K., Ketterer, J. L., Ullrich, A., Abbott, S., Barbarossa, M. V., Bertsimas, D., Bhatia, S., Bodych, M., Bosse, N. I., Burgard, J. P., Castro, L., Fairchild, G., Fuhrmann, J., Funk, S., Gogolewski, K., Gu, Q., … Schienle, M. (2021). A pre-registered short-term forecasting study of COVID-19 in Germany and Poland during the second wave. Nature Communications, 12(1), 5173. https://doi.org/10.1038/s41467-021-25207-0

and code, e.g.

sharpness <- sharpness * alpha / 2

say it is rather alpha / 2, correct?

@nikosbosse
Copy link
Contributor

Thank you very much for pointing this out! Yes alpha / 2 is correct and alpha / 4 was a typo. Will be fixing this together with a large package update in #166.

@seabbs seabbs linked a pull request Feb 3, 2022 that will close this issue
@nikosbosse nikosbosse mentioned this issue Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants