Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies #796

Closed
sbfnk opened this issue Sep 27, 2024 · 2 comments · Fixed by #798
Closed

Dependencies #796

sbfnk opened this issue Sep 27, 2024 · 2 comments · Fixed by #798

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Sep 27, 2024

With the recent switch to {cli} we now have 21 dependencies which is above CRAN's limit of 20 (not sure how strictly this is enforced). It would be good to consider which dependencies could be removed.

Candidates are:

  • {future}, {future.apply}, {futile logger} and remove corresponding functionality, potentially not ideal as might be breaking for people using this in production
  • {R.utils} - likewise only used for production for timing out long runs
  • {patchwork} only used for two plots - could they be faceted instead?
  • runner::mean_run() only used once, in create_shifted_cases(), also truncnorm::rtruncnorm only used in two places -- both of these could be re-implemented fairly trivially, but I'm not sure what the point of that would be.

Let's see how we do with the 1.6.0 submission and then potentially reconsider.

@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 27, 2024

progressr perhaps could be optional, as could all the future and futile stuff -- these would then only be used if available.

@seabbs
Copy link
Contributor

seabbs commented Sep 27, 2024

I think making the parallel functionality optional is a good idea that is the sensible solution. I don't have the sense that many people use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants