Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message explaining new behaviour when obs_opts(na = "missing") #771

Closed
jamesmbaazam opened this issue Sep 13, 2024 · 1 comment · Fixed by #774
Closed

Add message explaining new behaviour when obs_opts(na = "missing") #771

jamesmbaazam opened this issue Sep 13, 2024 · 1 comment · Fixed by #774
Assignees
@jamesmbaazam

Comments

@jamesmbaazam
Copy link
Contributor

Based on #767, @seabbs has suggested we add a message in obs_opts() to explain the new behaviour when na = missing. This will help users decide whether to use the new behaviour or retain the old one by preprocessing their data as suggested in #767 (comment).
@jamesmbaazam jamesmbaazam changed the title Add message about obs_opts(na = "missing") Add message explaining new behaviour when obs_opts(na = "missing") Sep 13, 2024
@sbfnk
Copy link
Contributor

sbfnk commented Sep 16, 2024

I agree, we should print a message when na is not set by the user and there are missing dates in the data.

Related comment and original change in #528 (comment)

@sbfnk sbfnk mentioned this issue Sep 16, 2024
Closed
@jamesmbaazam jamesmbaazam self-assigned this Sep 16, 2024
@jamesmbaazam jamesmbaazam mentioned this issue Sep 16, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmbaazam jamesmbaazam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle messaging around model treatment of missingness epiforecasts/EpiNow2
2 participants
@sbfnk @jamesmbaazam