Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify tolerance instead of max for distributions #533

Closed
sbfnk opened this issue Jan 16, 2024 · 2 comments · Fixed by #724
Closed

specify tolerance instead of max for distributions #533

sbfnk opened this issue Jan 16, 2024 · 2 comments · Fixed by #724
Assignees

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Jan 16, 2024

Instead of specifying the maximum one could support specifying a tolerance, i.e. minimum pmf / 1-cmf as is already implemented in the convolution (or the conversion to stan code if going with the approach in #504). This might require looping over incremental values of max to find the "correct" one.

@seabbs
Copy link
Contributor

seabbs commented Feb 8, 2024

Yes nice idea

@sbfnk sbfnk moved this to Todo in EpiNow2 v1.5.0 Feb 20, 2024
@sbfnk sbfnk removed this from EpiNow2 v1.5.0 Mar 18, 2024
@sbfnk
Copy link
Contributor Author

sbfnk commented Mar 19, 2024

As we can doing this in the conversion to stan code everywhere now, it is not a priority for v1.5.

@sbfnk sbfnk closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
@sbfnk sbfnk added this to the CRAN v1.6 release milestone May 17, 2024
@sbfnk sbfnk reopened this May 17, 2024
@sbfnk sbfnk self-assigned this May 28, 2024
@sbfnk sbfnk closed this as completed in #724 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants