Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value for generation_time in regional_epinow() #494

Closed
jamesmbaazam opened this issue Oct 30, 2023 · 1 comment · Fixed by #569
Closed

Fix default value for generation_time in regional_epinow() #494

jamesmbaazam opened this issue Oct 30, 2023 · 1 comment · Fixed by #569
Assignees
@jamesmbaazam
Labels
bug Something isn't working

Comments

@jamesmbaazam
Copy link
Contributor

the default argument for generation_time should be generation_time_opts() as in estimate_infections(), but that is an issue outside this PR.

Originally posted by @sbfnk in #476 (comment)
@sbfnk
Copy link
Contributor

sbfnk commented Oct 31, 2023

And in epinow()

@seabbs seabbs added the bug Something isn't working label Nov 1, 2023
@jamesmbaazam jamesmbaazam moved this to Todo in EpiNow2 v2.0.0 Nov 10, 2023
@jamesmbaazam jamesmbaazam removed the status in EpiNow2 v2.0.0 Nov 10, 2023
@sbfnk sbfnk removed this from EpiNow2 v2.0.0 Feb 20, 2024
@sbfnk sbfnk moved this to Todo in EpiNow2 v1.5.0 Feb 20, 2024
@jamesmbaazam jamesmbaazam self-assigned this Feb 21, 2024
@jamesmbaazam jamesmbaazam moved this from Todo to In Progress in EpiNow2 v1.5.0 Feb 21, 2024
@jamesmbaazam jamesmbaazam mentioned this issue Feb 21, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in EpiNow2 v1.5.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmbaazam jamesmbaazam

Labels
bug Something isn't working
Projects
EpiNow2 v1.5.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix default values for generation_time argument epiforecasts/EpiNow2
3 participants
@sbfnk @seabbs @jamesmbaazam