Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to add some manual text or analytics code to page #18

Open
bungabunga opened this issue Nov 16, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bungabunga
Copy link

bungabunga commented Nov 16, 2018

It would be great to have an option to add some additional text to my page if (when) needed. Also that feature would be useful to add some analytics code if needed.
Maybe that is already possible but I don't know how/where exactly I could do it.

@bungabunga bungabunga changed the title (feature e) Ability to add some manual text to page or analytics code [Feature Request] Ability to add some manual text or analytics code to page Nov 16, 2018
@epidrome epidrome added enhancement New feature or request wontfix This will not be worked on PR welcome labels Nov 16, 2018
@epidrome
Copy link
Owner

epidrome commented Nov 16, 2018

I have considered to include analytics in the original design, but I have been reluctant to add it.

Currently, there are several reasons against having analytics:

  1. The theme offers a single page, so there is not much to track with analytics
  2. If we add analytics, then we should also have several extra options in the configuration and the source code, because there is no single standard or preferred analytics provider
  3. The main goal of the theme is to be really minimal as described in the readme at the master branch, so we are looking to remove non-essential features rather than add extras

Of course, you can easily add analytics at your local version by modifying the default layout or even better, I am happy to accept a pull request that adds an include for a custom header file (similarly to too_social) that might contain the analytics code of preference for each installation.

@bungabunga
Copy link
Author

actually my question was more about some very minimalistic change, closer to minimalistic cover-card approach: just to be able to publish some personal text on your personal page when needed. but if you'de be able to do that you'd also be able to publish a few lines of code from Statcounter or something similar. so, no dramatic changes, cover-card would still stay simple.

@epidrome epidrome removed PR welcome wontfix This will not be worked on labels Dec 6, 2018
@epidrome
Copy link
Owner

epidrome commented Dec 6, 2018

The last couple of commits adds support for (virtually any type of) analytics snippet (or for any custom piece of code that one wants to put in the head): 76efc09

if you want to add something visible (e.g., stat counter) then it is suggested to override the default header: https://github.com/epidrome/cover-card/blob/master/_includes/header.html

e.g., an extra line after the end of , of course, this kind of edit increases the chances of breakage in a future major update

@epidrome epidrome added the good first issue Good for newcomers label Feb 6, 2019
@epidrome epidrome closed this as completed Feb 6, 2019
@epidrome epidrome reopened this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants