Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1625] Fix breadcrumbs router error #1627

Merged
merged 5 commits into from
Apr 7, 2022
Merged

[#1625] Fix breadcrumbs router error #1627

merged 5 commits into from
Apr 7, 2022

Conversation

RVitaly1978
Copy link
Member

Description

close #1625

changes:

  • fix isDisabled in VaBreadcrumbsItem and component minor updates
  • use ExtractPropType in useRouterLink
  • add comment /** @deprecated */ to mixins

chrome-capture
chrome-capture (1)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@RVitaly1978 RVitaly1978 added BUG Something isn't working component Is a new component or part of existing one labels Apr 5, 2022
@RVitaly1978 RVitaly1978 self-assigned this Apr 5, 2022
Derranion
Derranion requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@Derranion Derranion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we will try to navigate from the ...localhost/en/ui-elements/breadcrumbs to any other docs page we will receive this error:

i18n_error

Most likely caused by this Vue bug - update to 3.0.10 version may help.

Though we need to test it, new version may also add some TS errors but this should be manageable.

@m0ksem
Copy link
Collaborator

m0ksem commented Apr 6, 2022 •
edited
Loading

If we will try to navigate from the ...localhost/en/ui-elements/breadcrumbs to any other docs page we will receive this error:

i18n_error

Most likely caused by this Vue bug - update to 3.0.10 version may help.

Though we need to test it, new version may also add some TS errors but this should be manageable.

Yap. You can find more info here: https://github.com/epicmaxco/vuestic-ui/pull/1627/files#diff-02ef34fd350e2b5fc1ae6a62c3354e0b6fc335bff0c2e7e5f078c2eda5962a82

This issue closed 11 months ago in v3.1.0 Changelog. We can update vuestic's minimal vue version to 3.1.0 (or 3.2.0). @asvae

@RVitaly1978 RVitaly1978 requested a review from Derranion April 6, 2022 08:16
@RVitaly1978 RVitaly1978 merged commit 3f8f4d9 into epicmaxco:develop Apr 7, 2022
@RVitaly1978 RVitaly1978 deleted the fix/breadcrumbs branch April 7, 2022 13:14
aluarius pushed a commit to aluarius/vuestic-ui that referenced this pull request Apr 15, 2022
@RVitaly1978 @aluarius
[epicmaxco#1625] Fix breadcrumbs router error (epicmaxco#1627)
2fec578 
* feat: use ExtractPropType in useRouterLink

* fix: add deprecated comment to mixins

* fix: error in isDisabled, minor updates

* feat: add demo example with vertical breadcrumbs

* fix: brought back some changes, add extra comment

Co-authored-by: Vitaly Raicheu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aluarius aluarius aluarius approved these changes

@LighthouseKeeperYN LighthouseKeeperYN LighthouseKeeperYN approved these changes

@rustem-nasyrov rustem-nasyrov rustem-nasyrov approved these changes

@m0ksem m0ksem m0ksem approved these changes

@legit1One legit1One Awaiting requested review from legit1One

@Derranion Derranion Awaiting requested review from Derranion

Assignees

@RVitaly1978 RVitaly1978

Labels
BUG Something isn't working component Is a new component or part of existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

va-breadcrumbs router error
6 participants
@RVitaly1978 @m0ksem @Derranion @rustem-nasyrov @LighthouseKeeperYN @aluarius