Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicks and passing arguments are sometimes non operational on component root level #4262

Open
asvae opened this issue May 7, 2024 · 1 comment
Labels
BUG Something isn't working

Comments

@asvae
Copy link
Member

asvae commented May 7, 2024

Vuestic-ui version: 1.9.10

Description

  • For VaCounter when I set data-testid - it's getting set on child input element (.va-input__content__input) instead of root element (.va-counter). This is problematic for automated tests as it makes it hard to select an element.
  • Some elements, like VaSwitch and VaCheckbox if you el.click() on root element - click doesn't trigger.

Actionable

This issue doesn't seem too pressing, but pretty crucial if we want to have unified automated testing. To make it work we would need the following, I believe:

  • For all components check that attributes pass-through to root level element by default (in many cases child components can pick specific attributest for themselves, i.e. for VaCounter - all input props - should go to input).
    • Same for classes and styles
  • For all clickable elements - el.click() should work.

Reproduction

This is repro only for data-testid case.

(https://ui.vuestic.dev/play#eNp9Uctu2zAQ/BWCF9mALR1yM2QDbZBDCzQtmqKXsgeWWjtMxUfJpepC0L93ScWOEwSBIECand2ZnR35O+/rIQHf8DaqoD2yCJj8TljGtPEuIBtZgP2KOfvJJYvQsYntgzOsor5K2MxUzkZkJh7YNpMXVbXMcH7PbYvFkm13bMwgy9x6kH0C6uicSgYs1n8ShH930INCFxbVj06iXCNE1N1W8F/S0iP4z2pZq17GeCsN5GkTibXNbJ+M0w+C8b1EKGu0fncARG0PGyb4OBaf0yR428x7EgGOnkQfKYNcq+I5XHC+y+sZY6+7Yg3x2uZCWVi+4nOGayN9/RCdpZxLAOKxEAXfnCIh4ZSnqnXSGRb8HtHHTdMknW+US3UHQ3OiuYSNkdrSZMFLEMJOpImR7rHXhxeKyhmvewifPWq61zNl2ffu78eCYUiwOuHqHtTvV/CHeJwtfgkQIQwg+LmGMlDec/nm7haO9H0uGtelnthvFL9CdH3KHmfa+2Q7sn3BK24/lADpZN/izRHBxtNS2WhJo/BLqtdvrP5k96q+Oqc4/QfEPQjC)

@m0ksem
Copy link
Collaborator

m0ksem commented May 9, 2024

I face the same issue with input when working on devtools.

2024-05-09 at 11 55 42 - Magenta Cattle

Styles actually applied to input, instead of Input wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants