Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap preset option #122

Closed
annabel-dekker opened this issue Nov 27, 2024 · 4 comments
Closed

Minimap preset option #122

annabel-dekker opened this issue Nov 27, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@annabel-dekker
Copy link

Is your feature related to a problem?

We are testing your pipeline for our nanopore sequencing. However, we have an in-house solution that uses a form of rolling circle amplification to improve the quality of our reads. What we notice is that we can validate the kraken2 classifications, but the classifications of minimap2 are sometimes really poor (lots of false positives and poor mapping). We are wondering whether this might be due to the preset for map-ont (-x).

Describe the solution you'd like

The possibility to change the preset for minimap2 to test whether your pipeline can be used for different input data as well.

Describe alternatives you've considered

I could test this myself of course by digging through the workfolders and adjusting some code on the fly :), if I managed I will let you know if this made an impact.
Thanks again for thinking along in advance!

Additional context

No response

@nggvs
Copy link
Contributor

nggvs commented Dec 3, 2024

Hi @annabel-dekker ,
Thank you for your suggestion, if I understand it right you'd like to have minimap2 preset as a parameter no? I'd made an internal ticket to consider it in future releases.
Thank you for using the workflow and for your feedback!

@nggvs nggvs added the enhancement New feature or request label Dec 3, 2024
@annabel-dekker
Copy link
Author

I tested a manual run of minimap2 with -x map-hifi instead of map-ont; and as expected makes a huge difference in classification for our high quality nanopore reads. It would be very much appreciated to include this parameter in the next releases, so that we can test it better! :) Thanks a lot!

@nggvs
Copy link
Contributor

nggvs commented Dec 5, 2024

Hi @annabel-dekker ,
I have created a ticket to consider this feature for feature releases.
Thank you very much for using the workflow and for your feedback!

@nggvs nggvs closed this as completed Jan 13, 2025
@nggvs
Copy link
Contributor

nggvs commented Jan 13, 2025

Closing as it has been raised internally in a ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants