Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blurEffectStyle not working on iOS 10 #80

Closed
techseeko opened this issue Oct 17, 2016 · 6 comments
Closed

blurEffectStyle not working on iOS 10 #80

techseeko opened this issue Oct 17, 2016 · 6 comments

Comments

@techseeko
Copy link

techseeko commented Oct 17, 2016

It's a problem out there, for iOS 10, UIVisualEffectView does not blur when using UIBlurEffect in some cases. If anything is added to the UIVisualEffectView directly it might break the functionality, it should always be added to the UIVisualEffectView.contentView.

Also the presentationStyle should not be CrossDissolve this kind of view should be animated via UIView animation while setting the effect.

Can you please fix? If there's a workaround or anything that might help in this.

PS: Once we set the blurEffectStyle to .Dark all the views behind will show normally without blur effect, the background gets a bit darker, but it's not the intended behaviour since we can still read the text behind clearly and it affects all coach mark texts.

@ephread ephread added the bug label Oct 17, 2016
@ephread
Copy link
Owner

ephread commented Oct 17, 2016

Thanks for reporting the issue @techseeko. The UIVisualEffectView support indeed remains a bit sketchy due to a lack of time on my end.

If anything is added to the UIVisualEffectView directly it might break the functionality, it should always be added to the UIVisualEffectView.contentView.

Nothing is added to the UIVisualEffectView, the layer is manipulated and a mask is created. This is certainly what's causing the issue. I discovered few weeks ago that Apple now recommends to use the maskView property to create masks but I haven't had the time to look into it. This thread is especially interesting if you wish to fix the issue yourself (also take a look at OverlayView and OverlayViewLayerManager).

Also the presentationStyle should not be CrossDissolve this kind of view should be animated via UIView animation while setting the effect.

Due to limitations encountered at the time of iOS 8, the coach marks are not presented. Rather, everything is attached to the window. I've never been totally okay with this approach and I hope that, when dropping iOS 8, I'll be able to use window levels and presented view controllers mechanics.

@anfriis
Copy link

anfriis commented Feb 27, 2017

Does anyone have a fix for this ?

@ephread
Copy link
Owner

ephread commented Feb 27, 2017

@Anders123fr: I'm currently working on it. It requires some non trivial changes to the library, since the mask property on UIView is not animatable.

@anfriis
Copy link

anfriis commented Feb 27, 2017

Yeah I can imagine, but sounds great that you are working on it :)

@mureatencio
Copy link

Any fix for this behavior?

@ephread
Copy link
Owner

ephread commented Jun 3, 2017

Should now be fixed in master, a release will come tomorrow. It's not perfect (could use further optimization), but it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants