Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make run_calculator obselete in preference of a modified Calculator.run() #160

Open
elinscott opened this issue Jul 13, 2022 · 0 comments
Open
Assignees
Labels
enhancement New feature or request long-term

Comments

@elinscott
Copy link
Collaborator

elinscott commented Jul 13, 2022

Currently Workflow.run_calculator(), and Workflow.run_calculator_single() is a very clumsy way of creating calculators and giving these functions access to the workflow object.

Instead, there should be a Calculator objects should be given a workflow attribute that points back to the Workflow object, and then calc.run() should be able to do everything Workflow.run_calculator() currently does

Among other things, this will require...

  • calc.workflow to not be included in the json, but for calc.workflow to be recovered when loading a Workflow from json
  • the StumblingWorkflow to be rewritten because it redefines run_calculator_single()

It may also be worth thinking about if Workflow.new_calculator() is the best way of creating new calculators.

@elinscott elinscott self-assigned this Jul 13, 2022
@elinscott elinscott added enhancement New feature or request long-term labels Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request long-term
Projects
None yet
Development

No branches or pull requests

1 participant