You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently Workflow.run_calculator(), and Workflow.run_calculator_single() is a very clumsy way of creating calculators and giving these functions access to the workflow object.
Instead, there should be a Calculator objects should be given a workflow attribute that points back to the Workflow object, and then calc.run() should be able to do everything Workflow.run_calculator() currently does
Among other things, this will require...
calc.workflow to not be included in the json, but for calc.workflow to be recovered when loading a Workflow from json
the StumblingWorkflow to be rewritten because it redefines run_calculator_single()
It may also be worth thinking about if Workflow.new_calculator() is the best way of creating new calculators.
The text was updated successfully, but these errors were encountered:
Currently
Workflow.run_calculator()
, andWorkflow.run_calculator_single()
is a very clumsy way of creating calculators and giving these functions access to the workflow object.Instead, there should be a
Calculator
objects should be given aworkflow
attribute that points back to theWorkflow
object, and thencalc.run()
should be able to do everythingWorkflow.run_calculator()
currently doesAmong other things, this will require...
calc.workflow
to not be included in the json, but forcalc.workflow
to be recovered when loading aWorkflow
from jsonStumblingWorkflow
to be rewritten because it redefinesrun_calculator_single()
It may also be worth thinking about if
Workflow.new_calculator()
is the best way of creating new calculators.The text was updated successfully, but these errors were encountered: