Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test:e2e script for 'lib' package #522

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix test:e2e script for 'lib' package #522

merged 1 commit into from
Feb 22, 2024

Conversation

NataliaDSmirnova
Copy link
Collaborator

Description

  • after recent 'rimraf' version update accepted path format changed. now we have to use '--glob' for paths containing wildcard.

Type of changes

  • Bug fix (non-breaking change that fixes an issue)

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • I have added tests that prove my fix/feature works OR The changes do not require updated tests.
  • I have added the necessary documentation OR The changes do not require updated docs.

@NataliaDSmirnova NataliaDSmirnova marked this pull request as draft February 22, 2024 17:26
@coveralls
Copy link

Coverage Status

coverage: 25.05%. remained the same
when pulling b6a762f on fix-e2e-tests-path
into fe93aa1 on main.

@NataliaDSmirnova NataliaDSmirnova marked this pull request as ready for review February 22, 2024 22:18
paulsmirnov
paulsmirnov approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@paulsmirnov paulsmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for running e2e tests! (and fixing them)

@NataliaDSmirnova NataliaDSmirnova merged commit 25fea24 into main Feb 22, 2024
4 checks passed
@NataliaDSmirnova NataliaDSmirnova deleted the fix-e2e-tests-path branch February 22, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulsmirnov paulsmirnov paulsmirnov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NataliaDSmirnova @coveralls @paulsmirnov