You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use generated abi for ship, Requested PR should update the abieos submodule and utilize the generated generated ship abi json instead of the hard coded one.
fwiw, my understanding of that change seems backwards then what I'd expect. That change seemed like it was making ship_protocol.hpp in abieos be the source of truth for nodeos. It's weird imo to have abieos -- a serialization library -- defining the truth for how ship should work in nodeos.
Quite possibly ship_protocol.hpp should be part of mandel repo.
Anyways, this likely deserves further discussion somewhere before proceeding I think
Use generated abi for ship, Requested PR should update the abieos submodule and utilize the generated generated ship abi json instead of the hard coded one.
EOSIO/eos#10882
The text was updated successfully, but these errors were encountered: