Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: [statehist] Use generated abi for ship #469

Open
vladtr opened this issue Jun 20, 2022 · 2 comments
Open

Backport: [statehist] Use generated abi for ship #469

vladtr opened this issue Jun 20, 2022 · 2 comments
Labels
planning Propose change to milestone in next planning meeting

Comments

@vladtr
Copy link
Contributor

vladtr commented Jun 20, 2022

Use generated abi for ship, Requested PR should update the abieos submodule and utilize the generated generated ship abi json instead of the hard coded one.

EOSIO/eos#10882

@vladtr vladtr changed the title Backport: [statehist] Backport: [statehist] Use generated abi for ship Jun 20, 2022
@vladtr vladtr moved this to Todo in ENF Engineering Jul 1, 2022
@arhag arhag added this to the Mandel 3.2.0-rc1 milestone Jul 1, 2022
@spoonincode
Copy link
Member

fwiw, my understanding of that change seems backwards then what I'd expect. That change seemed like it was making ship_protocol.hpp in abieos be the source of truth for nodeos. It's weird imo to have abieos -- a serialization library -- defining the truth for how ship should work in nodeos.

Quite possibly ship_protocol.hpp should be part of mandel repo.

Anyways, this likely deserves further discussion somewhere before proceeding I think

@vladtr vladtr self-assigned this Jul 7, 2022
@vladtr vladtr moved this from Todo to In Progress in ENF Engineering Jul 7, 2022
@vladtr vladtr added the planning Propose change to milestone in next planning meeting label Jul 7, 2022
@arhag arhag removed this from the Mandel 3.2.0-rc1 milestone Jul 7, 2022
@arhag arhag unassigned vladtr Jul 8, 2022
@stephenpdeos stephenpdeos moved this from In Progress to Todo in ENF Engineering Jul 28, 2022
@spoonincode
Copy link
Member

Some work done in AntelopeIO/leap#458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planning Propose change to milestone in next planning meeting
Projects
Status: Todo
Development

No branches or pull requests

3 participants