Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider importing BUILD.bazel overlays as static variables #2

Closed
aaronmondal opened this issue Jun 3, 2022 · 3 comments
Closed

Consider importing BUILD.bazel overlays as static variables #2

aaronmondal opened this issue Jun 3, 2022 · 3 comments

Comments

@aaronmondal
Copy link
Contributor

bazelbuild/bazel#14659 prevents us from leveraging our registry.

We can probably work around this by moving the third-party-overlays/*.BUILD.bazel to static variables.
@aaronmondal aaronmondal changed the title Switch from BUILD.bazel overlays to separate modules Consider importing BUILD.bazel overlays as static variables Jun 3, 2022
@aaronmondal
Copy link
Contributor Author

Fixed in 01f8732. As soon as the bug is resolved we will switch back, as the current solution doesn't let buildifier analyze the build files.

Registry builds still don't work, but that's an issue with the patches for the clang overlay and not related to the bug.

@neqochan
Copy link
Contributor

Bazel bug has been fixed. Waiting for next prerelease so that we can revert.

@neqochan
Copy link
Contributor

neqochan commented Jul 1, 2022

Switched to upstream bazel CI artifacts that contain the fix. Workaround has been reverted.

@neqochan neqochan closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronmondal @neqochan