Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setProps: fix callback support #1716

Closed
ljharb opened this issue Jul 17, 2018 · 1 comment
Closed

setProps: fix callback support #1716

ljharb opened this issue Jul 17, 2018 · 1 comment
Labels
API: shallow bug help wanted

Comments

@ljharb
Copy link
Member

ljharb commented Jul 17, 2018 •
edited
Loading

See https://github.com/airbnb/enzyme/compare/setProps and https://travis-ci.org/airbnb/enzyme/builds/406918917 for the failing tests, on basically all react versions.

A PR that makes these tests pass (or corrects them, if they're wrong) would be greatly appreciated!
@emuraton emuraton mentioned this issue Jul 22, 2018
Merged
@emuraton
Copy link
Contributor

Hi,
I worked on this issue today and created this PR: #1721

its my first contribution, tell me if something is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API: shallow bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @emuraton