Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr:ac 1.1.7 crashes when scanning Audio CDs #457

Open
winfr34k opened this issue Mar 14, 2023 · 7 comments
Open

fr:ac 1.1.7 crashes when scanning Audio CDs #457

winfr34k opened this issue Mar 14, 2023 · 7 comments
Labels

Comments

@winfr34k
Copy link

winfr34k commented Mar 14, 2023

Describe the bug
fre:ac crashes as soon as it starts to scan the audio CD in the drive.

To Reproduce
Steps to reproduce the behavior:

  1. Have an Audio CD in your drive (in my case this is USB attached)
  2. Click on 'Add audio CD contents to the joblist' (2nd button in the top menu)
  3. No tracks get added to the joblist
  4. Observe a hard crash after accessing the CD drive

Expected behavior
CD drive access works fine and all tracks are added to the joblist, no crash happens.

Screenshots
None.

System (please complete the following information)

  • OS: macOS 13.2.1 Ventura
  • CPU: Apple Silicon M1 Pro 10c/16c
  • RAM: 32 GB

Additional context
fre:ac was installed using Homebrew. Find the crash report attached as a file.
crash.txt

@winfr34k winfr34k added the bug label Mar 14, 2023
@enzo1982
Copy link
Owner

Thank you for reporting this!

This is a bug in the libcdio library used by fre:ac to read CDs on macOS. It only affects macOS Ventura, not earlier versions of macOS.

The latest continuous build fixes the issue by adding a patch to libcdio. I will also release a fre:ac 1.1.7a hotfix for macOS soon to fix this issue in an official release, but I'm still investigating another issue that should be fixed in that update.

@winfr34k
Copy link
Author

Is there anything I can help with to accelerate a fixup release for macOS? I know the latest and greatest build fixes it but so far I've had to uninstall and reinstall freac 5 times to resolve this :D

@enzo1982
Copy link
Owner

Well, you wrote that you installed fre:ac using Homebrew. The bug is in libcdio, so even if I released a fre:ac update now, the Homebrew version would still have the issue until the fix is integrated into Homebrew's libcdio.

I don't know whether you are a Homebrew contributor or have experience writing Homebrew formulas. If you do, the libcdio formula will have to be updated with this patch from the libcdio repository to fix the issue. This is independent of fre:ac, so fixing the libcdio formula will fix Homebrew's fre:ac 1.1.7 without any fre:ac update needed.

@winfr34k
Copy link
Author

The fre:ac formula in Homebrew is a Cask, i.e. it's just the regular .app getting managed via Homebrew. That means that it uses the cdio.dylib that is bundled with the app.

However, applying this patch to the libcdio formula is still a good idea and I'll try to bring that in. This way, I could talk to the Homebrew project members and find out if they'd accept a patch to depend on libcdio and remove the .dylib via a postfight action. I'm quite certain that's a big no-go to them, though.

The hotfix still seems to be the most straightforward solution :-/

@riskieee
Copy link

riskieee commented Jul 13, 2024

Freac (1.1.7 & continuous build 20240510) crashes on CD reading on macOS Sonoma 14.5 on Apple M3 Max

@winfr34k
Copy link
Author

@riskieee Until this app with the patched cdio.dylib gets released, you can do this:

$ brew install --cask --force https://raw.githubusercontent.com/Homebrew/homebrew-cask/d2175ab232d9fe29f99e9b03bc3c3fa754bcc2df/Casks/freac.rb

This just installs version 1.1.6 over 1.1.7. I've been doing this for the last year to rip CDs... I've never followed through with trying to build a patched .dylib and adding it to the formulae, sorry.

@riskieee
Copy link

... also thought about downgrading and after switching back from gnudb.gnudb.org to freedb.freac.org all works fine 👍

Don't know when next fixed macOS release is coming but would add another download link for 1.1.6. with a warning 1.1.7. is broken on macOS silicon ...

THX and keep up this great tool! Love using freac as best tool in class on any OS 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants