Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Test: test_adapt #254

Open
mabruzzo opened this issue Jul 11, 2022 · 1 comment
Open

Failing Test: test_adapt #254

mabruzzo opened this issue Jul 11, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@mabruzzo
Copy link
Contributor

PR #248 fixes the errors with linking the unit tests. Because the unit tests have not been run since we migrated to CMake, a change was made that causes the test_adapt unit test to fail. This could potentially be indicative of a problem.

On a branch including the changes of PR #248:

  • To build this test, you can call make test_adapt (or ninja test_adapt) from the build directory.
  • You can run the test by calling ./bin/test_adapt from the build directory.

This is currently disabled from the build system. After fixing this problem, you can re-enable this test by uncomenting the following line in test/CMakeLists.txt

#setup_test_unit(Assorted-Adapt Assorted/Adapt test_adapt)
@mabruzzo mabruzzo added the bug Something isn't working label Jul 11, 2022
@pgrete
Copy link
Contributor

pgrete commented Jul 13, 2022

If I remember correctly (and my quick grep in the old tree was also correct), this test was never used/called in the original infrastructure so it may as well be obsolete/outdated/defunct rather than a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants