Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data download does not work #152

Open
mfbehrens99 opened this issue Jun 8, 2023 · 3 comments
Open

Data download does not work #152

mfbehrens99 opened this issue Jun 8, 2023 · 3 comments
Assignees
Labels
bug Something that went wrong install Problems with installation
Milestone

Comments

@mfbehrens99
Copy link

When I try to run it, it says: "Cannot download data."

Maybe there has been an update in urllib3.

Changing osm/osm_getter.py lin 74 from result = pool_manager.request("GET", address, parameters) to result = pool_manager.request("GET", address, fields=parameters) fixed it for me

@fazalmajid
Copy link

fazalmajid commented Jul 8, 2023

urllib3 2.0 creates all sort of breakage, some distros like Alpine Linux have chosen to revert. Thanks for the resolution!

@enzet
Copy link
Owner

enzet commented Jul 9, 2023

Oh, I see, there is new syntax in urllib3 version 2 for request() function and I have urllib3>=1.25.6 instead of urllib3~=1.25.6 in requirements.txt file. I will fix that (probably not upgrading to version 2 because of @fazalmajid comment).

@mfbehrens99 Could you please create a pull request, or send me a patch, or at least provide your name/email so that I can apply the patch in your name?

@enzet enzet self-assigned this Jul 9, 2023
@enzet enzet added bug Something that went wrong install Problems with installation labels Jul 9, 2023
@enzet enzet added this to the 0.2 milestone Jul 9, 2023
@eliandoran
Copy link

@enzet , would it be possible to carry on with this fix? I've just had the same issue.
I see there is a PR handling this in #157.
With that fix applied, everything seems to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that went wrong install Problems with installation
Projects
Status: Answer From Author Needed
Development

No branches or pull requests

4 participants