Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to ESP32? #83

Open
sauvant opened this issue Dec 31, 2020 · 10 comments
Open

Port to ESP32? #83

sauvant opened this issue Dec 31, 2020 · 10 comments

Comments

@sauvant
Copy link

sauvant commented Dec 31, 2020

Hi,

I am very interested in this project but it would need to run on ESP32s for me. Do you have any plans to port it? Or has anybody done that already?

Thanks and best regards
Keith

@c-o-m-m-a-n-d-e-r
Copy link

c-o-m-m-a-n-d-e-r commented Jan 11, 2021

I#m very interessted too ... having some ESP8266 running with this Lib an it works great.

Now i will test some ESP32 Devices with KNX to :-)

EDIT : Ok i saw you don't own a ESP32 .. i will give it a try :-)

@c-o-m-m-a-n-d-e-r
Copy link

Please give it a try : https://github.com/c-o-m-m-a-n-d-e-r/esp-knx-ip

This is just a quick try ... first look was ok for me ...
will do an PR if everything is fine.

@cbovy
Copy link

cbovy commented Jan 26, 2021

@c-o-m-m-a-n-d-e-r For me it works on ESP32 (Lolin D32) with your repo.
Not sure why 'send_14byte_string' is removed though.

@c-o-m-m-a-n-d-e-r
Copy link

i'm also not sure haha ... will take a look why this was removed.

@NilsRo
Copy link

NilsRo commented Mar 14, 2021

If everything fine? Have a ESP32 here and like to connect it to my KNX at home to control a dehumidifier, but your change is still not in the master if I am right?

@spacegaier
Copy link

spacegaier commented Mar 14, 2021

@NilsRo There was never a PR for ESP32 created against this main repo here, so nothing to be merged exists yet.

@c-o-m-m-a-n-d-e-r Do you plan to create one?

@c-o-m-m-a-n-d-e-r
Copy link

Yeahr ... totally forgot this ... sorry guys ... will try to check changes and make PR then

@mrWheel
Copy link

mrWheel commented Mar 20, 2022

Is there a chance this great library will be ported to ESP32 in the near future?

With the latest esp32-core I get tons of compiler errors. It looks like the WiFi lib for the esp32 is not compatible with this library.

This is the first error I encounter. is there a solution for this error:

In file included from …/esp-knx-ip.cpp:7:
esp32-knx-ip.h:231:33: error: flexible array member in union
    cemi_addi_t additional_info[];

According to an answer at stackoverflow:

No, unions do not support flexible array members, only structs. C11 6.7.2.1 §18

As a special case, the last element of a structure with more than one named member may have an 
incomplete array type; this is called a flexible array member.
In addition, zero-length arrays is not valid C, that's a gcc non-standard extension. The reason why 
you get this to work is because your compiler, gcc, is configured to compile code for the "non-standard 
GNU language".

@jamel-86
Copy link

jamel-86 commented Oct 4, 2023

I got some errors in the newer versions of Arduino IDE.
I have forked a new ESP32 port here: https://github.com/jamel-86/ESP32_KNX_IP_Library

hope someone finds it useful 👍

@jamel-86
Copy link

jamel-86 commented Oct 4, 2023

Is there a chance this great library will be ported to ESP32 in the near future?

With the latest esp32-core I get tons of compiler errors. It looks like the WiFi lib for the esp32 is not compatible with this library.

This is the first error I encounter. is there a solution for this error:

In file included from …/esp-knx-ip.cpp:7:
esp32-knx-ip.h:231:33: error: flexible array member in union
cemi_addi_t additional_info[];
According to an answer at stackoverflow:

No, unions do not support flexible array members, only structs. C11 6.7.2.1 §18

As a special case, the last element of a structure with more than one named member may have an
incomplete array type; this is called a flexible array member.
In addition, zero-length arrays is not valid C, that's a gcc non-standard extension. The reason why
you get this to work is because your compiler, gcc, is configured to compile code for the "non-standard
GNU language".

Try to change:

cemi_addi_t additional_info[];

with:

cemi_addi_t additional_info[i];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants