Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the default hitsAddend configurable #730

Open
gcalmettes opened this issue Oct 10, 2024 · 1 comment · May be fixed by #729
Open

Make the default hitsAddend configurable #730

gcalmettes opened this issue Oct 10, 2024 · 1 comment · May be fixed by #729

Comments

@gcalmettes
Copy link

The current minimum hitsAddend value is set to 1 (enforced via a Max function). This prevents uses cases where the request itself would not carry any "weight" (e.g.: request to check a quota).

Could we make the minimum hitsAddend value configurable so 0 could also be a possible hitsAddend value for a request ?
@gcalmettes gcalmettes linked a pull request Oct 10, 2024 that will close this issue
Open
@gcalmettes
Copy link
Author

PR for a proposed implementation, leveraging the current Settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make default hitsAddend minimum value configurable gcalmettes/ratelimit
1 participant
@gcalmettes