Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to clear rate limits? #191

Open
vincentjames501 opened this issue Nov 16, 2020 · 3 comments
Open

Method to clear rate limits? #191

vincentjames501 opened this issue Nov 16, 2020 · 3 comments

Comments

@vincentjames501
Copy link

I think it would be neat for the /json API route to accept a DELETE request which clears the matching Redis keys. For example, when a user successfully enters their password correctly, we reset the rate limits for that user. I realize this wouldn't be something Envoy would call directly, but something a different service could call directly.

@patramsey
Copy link

@vincentjames501 I've been working on this over here and with the proto definitions here as I also required resetting a rate. On calling the /json endpoint with the DELETE HTTP verb it will reset the local in memory cache, memcached or redis for a given set of descriptors. Resets can also be done via gRPC and I've included a new flag in the gRPC client to do the reset.

@patramsey
Copy link

@mattklein123 I've reused the RateLimitResponse type for the ResetRateLimit response. https://github.com/patramsey/go-control-plane/blob/main/envoy/service/ratelimit/v3/rls.pb.go#L739

Should that call have its own response type instead? ResetRateLimitResponse ?

@damonavi
Copy link

Is there any update on this issue. Does the above branch implementation work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants