From 22dbdeae81bbdf4ddd3b51afc023f5924856f15f Mon Sep 17 00:00:00 2001 From: Javier Ruiz Arduengo Date: Thu, 9 Sep 2021 12:01:23 -0400 Subject: [PATCH] Add TODO in settings.go and remove readme line Signed-off-by: Javier Ruiz Arduengo --- README.md | 2 -- src/settings/settings.go | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 52788d00..15a8115d 100644 --- a/README.md +++ b/README.md @@ -542,8 +542,6 @@ As well Ratelimit supports TLS connections and authentication. These can be conf 1. `REDIS_AUTH` & `REDIS_PERSECOND_AUTH`: set to `"password"` to enable authentication to the redis host. 1. `CACHE_KEY_PREFIX`: a string to prepend to all cache keys -Ratelimit also provides the ability to specify TLS settings via `RedisTlsConfig` in the [settings](https://github.com/envoyproxy/ratelimit/blob/master/src/settings/settings.go). - ## Redis type Ratelimit supports different types of redis deployments: diff --git a/src/settings/settings.go b/src/settings/settings.go index 8c4be146..4c5c1131 100644 --- a/src/settings/settings.go +++ b/src/settings/settings.go @@ -49,7 +49,8 @@ type Settings struct { RedisPoolSize int `envconfig:"REDIS_POOL_SIZE" default:"10"` RedisAuth string `envconfig:"REDIS_AUTH" default:""` RedisTls bool `envconfig:"REDIS_TLS" default:"false"` - RedisTlsConfig *tls.Config + // TODO: Make this setting configurable out of the box instead of having to provide it through code. + RedisTlsConfig *tls.Config // RedisPipelineWindow sets the duration after which internal pipelines will be flushed. // If window is zero then implicit pipelining will be disabled. Radix use 150us for the