Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper Log Messaging at Startup #799

Closed
danehans opened this issue Dec 12, 2022 · 1 comment · Fixed by #800
Closed

Improper Log Messaging at Startup #799

danehans opened this issue Dec 12, 2022 · 1 comment · Fixed by #800
Labels
kind/bug Something isn't working
Milestone
0.3.0-rc.1

Comments

@danehans
Copy link
Contributor

EG includes the following message during startup:

$ kubectl logs deploy/envoy-gateway -n envoy-gateway-system -f
...
2022-12-12T18:57:14.880Z	INFO	kubernetes/controller.go:737	status subscriber shutting down	{"runner": "provider"}
...

However, status subscriber shutting down should not be triggered unless EG is shutting down.

xref #702 for adding subscribeAndUpdateStatus(). We should consider calling message.HandleSubscription functions at the end of processXXX() functions (one for Gateway, HTTPRoute, and TLSRoute objects).
@danehans danehans added the kind/bug Something isn't working label Dec 12, 2022
@danehans danehans added this to the 0.3.0-rc.1 milestone Dec 12, 2022
@danehans
Copy link
Contributor Author

@chauhanshubham PTAL.

@danehans danehans mentioned this issue Dec 12, 2022
Closed
@chauhanshubham chauhanshubham mentioned this issue Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
0.3.0-rc.1
Development

Successfully merging a pull request may close this issue.

fix status subscriber shutdown log chauhanshubham/gateway
1 participant
@danehans