Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra Manager updates Service failed and trigger svc/deployment wrongly #746

Closed
Xunzhuo opened this issue Nov 22, 2022 · 2 comments
Closed

Infra Manager updates Service failed and trigger svc/deployment wrongly #746

Xunzhuo opened this issue Nov 22, 2022 · 2 comments
Assignees
@Xunzhuo
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. kind/bug Something isn't working
Milestone
0.3.0-rc.1

Comments

@Xunzhuo
Copy link
Member

Xunzhuo commented Nov 22, 2022 •
edited
Loading

Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

Infra Manager updates Service Failed and Wrongly

  • Update Service Failed:

企业微信截图_ef8a2076-e871-4aa0-8b50-3e17f506b6cf

It can be reproduced after update Gateway CR.

  • Update Service Wrongly:

We should not simply use deep copy to compare if svc has changed: https://github.com/envoyproxy/gateway/blob/main/internal/infrastructure/kubernetes/service.go#L95

We should just compare a couple of specific vars. (Some vars in svc spec are fullfiled by k8s itself).

When restarting envoy gateway, without anychanges to gateway CR, it will be updated wrongly.
@Xunzhuo Xunzhuo added the kind/bug Something isn't working label Nov 22, 2022
@Xunzhuo Xunzhuo mentioned this issue Nov 22, 2022
Merged
@Xunzhuo Xunzhuo changed the title Infra Manager updates Service Failed and Wrongly Infra Manager updates Service failed and trigger svc/deployment wrongly Nov 22, 2022
@Xunzhuo Xunzhuo self-assigned this Nov 22, 2022
@Xunzhuo Xunzhuo added this to the 0.3.0-rc.1 milestone Nov 22, 2022
@Xunzhuo Xunzhuo added the area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. label Nov 22, 2022
@danehans
Copy link
Contributor

danehans commented Dec 6, 2022

Now that #702 has merged, can you confirm this bug still exists?

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Jan 4, 2023

Close this since it is not reproduced again.

@Xunzhuo Xunzhuo closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xunzhuo Xunzhuo

Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. kind/bug Something isn't working
Projects
None yet
Milestone
0.3.0-rc.1
Development

No branches or pull requests
2 participants
@danehans @Xunzhuo