-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/Tests: documentation and e2e tests for Datadog tracing #4480
Conversation
Signed-off-by: Hartigan <[email protected]>
Signed-off-by: Hartigan <[email protected]>
@zirain , may you take a look? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4480 +/- ##
==========================================
+ Coverage 65.80% 65.84% +0.04%
==========================================
Files 203 203
Lines 30696 30699 +3
==========================================
+ Hits 20200 20215 +15
+ Misses 9341 9333 -8
+ Partials 1155 1151 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hartigan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, thanks for adding this.
/retest |
Now the pipeline looks like [Envoy] -> [Alloy] -> [OTel-collecotr] -> [Tempo], right? |
@zirain yes. |
Signed-off-by: Hartigan <[email protected]>
2cc4506
to
149e937
Compare
Signed-off-by: Hartigan <[email protected]>
Now test uses only |
@zirain should I mention somebody for additional review or approval? |
thanks for also adding docs and e2e @Hartigan ! |
Hi
This PR introduce documentation and end-to-end tests for Datadog tracing which added in #4298
End-to-end test implemented via Grafana Alloy, where Alloy acts as adapter from Datadog agent interface into
OpenTelemetry
format.Thanks