Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/Tests: documentation and e2e tests for Datadog tracing #4480

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

Hartigan
Copy link
Contributor

Hi

This PR introduce documentation and end-to-end tests for Datadog tracing which added in #4298

End-to-end test implemented via Grafana Alloy, where Alloy acts as adapter from Datadog agent interface into OpenTelemetry format.

Thanks

@Hartigan
Copy link
Contributor Author

@zirain , may you take a look?

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.84%. Comparing base (5a1c065) to head (149e937).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4480      +/-   ##
==========================================
+ Coverage   65.80%   65.84%   +0.04%     
==========================================
  Files         203      203              
  Lines       30696    30699       +3     
==========================================
+ Hits        20200    20215      +15     
+ Misses       9341     9333       -8     
+ Partials     1155     1151       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hartigan <[email protected]>
Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, thanks for adding this.

@zirain
Copy link
Member

zirain commented Oct 19, 2024

/retest

@zirain
Copy link
Member

zirain commented Oct 19, 2024

Now the pipeline looks like [Envoy] -> [Alloy] -> [OTel-collecotr] -> [Tempo], right?
Does OTel-collector[-contrib] could play as Datadog backend?

@Hartigan
Copy link
Contributor Author

Hartigan commented Oct 19, 2024

@zirain yes.
Looks like Opentelemetry collector has Datadog receiver support. I may try rewrite test without Alloy.

@Hartigan Hartigan force-pushed the main branch 2 times, most recently from 2cc4506 to 149e937 Compare October 19, 2024 22:54
Signed-off-by: Hartigan <[email protected]>
@Hartigan
Copy link
Contributor Author

Now test uses only opentelemetry-collector without Alloy. Also, I updated opentelemetry-collector to 0.108.0

@Hartigan Hartigan marked this pull request as ready for review October 19, 2024 23:06
@Hartigan Hartigan requested a review from a team as a code owner October 19, 2024 23:06
@Hartigan
Copy link
Contributor Author

@zirain should I mention somebody for additional review or approval?

@arkodg
Copy link
Contributor

arkodg commented Oct 21, 2024

thanks for also adding docs and e2e @Hartigan !

@arkodg arkodg merged commit 33ac6ca into envoyproxy:main Oct 21, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants