Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a HTTPRouteFilterExtensionRef for Envoy Gateway #4120

Closed
arkodg opened this issue Aug 28, 2024 · 10 comments · Fixed by #4258
Closed

Consider adding a HTTPRouteFilterExtensionRef for Envoy Gateway #4120

arkodg opened this issue Aug 28, 2024 · 10 comments · Fixed by #4258
Assignees
Labels
area/api API-related issues
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Aug 28, 2024

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

The project has been able to add functionality not yet defined in the Gateway API using Extensions

However some features that naturally live at the rule level within a xRoute that are API specific, dont fit well within Policies such as

Adding support for these features in the Gateway API will take time, since building a common API across multiple implementations is not a trivial task, however this is impacting users migrating to Envoy Gateway from other projects who are unable to do so because these common features dont exist yet

Raising this issue to propose adding a new CRD that can be attached to a HTTPRoute rule using the extensionRef field within HTTPRoute https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io/v1.HTTPRouteFilter

@arkodg arkodg added the triage label Aug 28, 2024
@arkodg
Copy link
Contributor Author

arkodg commented Aug 28, 2024

wdyt @envoyproxy/gateway-maintainers @envoyproxy/gateway-reviewers

@arkodg arkodg added kind/decision A record of a decision made by the community. and removed triage labels Aug 28, 2024
@arkodg arkodg modified the milestone: v1.2.0-rc1 Aug 28, 2024
@zirain
Copy link
Member

zirain commented Sep 1, 2024

for #2714 do we need to wait kubernetes-sigs/gateway-api#2826?

@arkodg
Copy link
Contributor Author

arkodg commented Sep 3, 2024

for #2714 do we need to wait kubernetes-sigs/gateway-api#2826?

yah we can wait or implement this via an extension (highlighted in this PR)

@guydc
Copy link
Contributor

guydc commented Sep 3, 2024

Also consider using this for: #3173

@guydc
Copy link
Contributor

guydc commented Sep 3, 2024

+1 to the filter approach. Would like to see this in 1.2.0.

@zirain
Copy link
Member

zirain commented Sep 4, 2024

for #2714 do we need to wait kubernetes-sigs/gateway-api#2826?

yah we can wait or implement this via an extension (highlighted in this PR)

Upstream will not implement it before v1.3(which seems too long), +1 to the filter approach.

@arkodg
Copy link
Contributor Author

arkodg commented Sep 5, 2024

+1, reg naming, HTTPFilter feels like a safe umbrella term to stash all the features under

@zhaohuabing
Copy link
Member

+1 on adding an umbrella HTTPFilter to hold all rule-specific features.

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 6, 2024

+1 for adding it as an general route level filter

@Alice-Lilith
Copy link
Member

+1 for the approach and HTTPFilter

@arkodg arkodg added help wanted Extra attention is needed area/api API-related issues and removed kind/decision A record of a decision made by the community. labels Sep 6, 2024
@arkodg arkodg added this to the v1.2.0-rc1 milestone Sep 6, 2024
@arkodg arkodg removed the help wanted Extra attention is needed label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants