Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix basic-auth.md formatting #4034

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

LiorLieberman
Copy link
Contributor

fix basic-auth.md formatting

@LiorLieberman LiorLieberman requested a review from a team as a code owner August 12, 2024 15:25
guydc
guydc previously approved these changes Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (6066f5a) to head (05c07c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4034   +/-   ##
=======================================
  Coverage   67.93%   67.94%           
=======================================
  Files         187      187           
  Lines       23027    23027           
=======================================
+ Hits        15643    15645    +2     
+ Misses       6269     6268    -1     
+ Partials     1115     1114    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Contributor

arkodg commented Aug 12, 2024

thanks for fixing this @LiorLieberman
can you also update the same content by copying the file into site/content/en/v1.0/tasks/security/basic-auth.md & site/content/en/v1.1/tasks/security/basic-auth.md

zirain
zirain previously approved these changes Aug 13, 2024
@zirain
Copy link
Member

zirain commented Aug 14, 2024

@LiorLieberman can you make CI happy?

LiorLieberman and others added 3 commits August 18, 2024 19:37
Signed-off-by: Lior Lieberman <[email protected]>
Signed-off-by: Lior Lieberman <[email protected]>
Signed-off-by: Lior Lieberman <[email protected]>
@zirain zirain merged commit 7c1d509 into envoyproxy:main Aug 19, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants