Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret / configmap updates do not trigger a reconcile #3496

Closed
alexwo opened this issue May 29, 2024 · 3 comments
Closed

Secret / configmap updates do not trigger a reconcile #3496

alexwo opened this issue May 29, 2024 · 3 comments
Assignees

Comments

@alexwo
Copy link
Contributor

alexwo commented May 29, 2024

Description:
Secret and configmap updates do not trigger a reconcile.
This can impact certificate changes and certain rotation procedures, config updates.

Repro steps:
Since secrets don’t have a spec or generation field, this predicate causes us to ignore any updates to secret keys. Completely replacing the secret will trigger reconciliation, but if someone only updates the secret keys, those changes will be skipped.

https://github.com/envoyproxy/gateway/blob/main/internal/provider/kubernetes/controller.go#L1209

@alexwo alexwo added the triage label May 29, 2024
@alexwo alexwo changed the title Secret changes (updates) do not trigger a reconcile Secret / configmap updates do not trigger a reconcile May 29, 2024
@alexwo
Copy link
Contributor Author

alexwo commented May 29, 2024

/assign

@alexwo
Copy link
Contributor Author

alexwo commented May 29, 2024

related -> #3500

@shawnh2
Copy link
Contributor

shawnh2 commented May 30, 2024

Fixed in favor of #3499

@shawnh2 shawnh2 closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants