Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc broken link: the squash link in contributing page broken #3005

Closed
wilsonwu opened this issue Mar 25, 2024 · 1 comment · Fixed by #3013
Closed

Doc broken link: the squash link in contributing page broken #3005

wilsonwu opened this issue Mar 25, 2024 · 1 comment · Fixed by #3013
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@wilsonwu
Copy link
Contributor

Description:
https://gateway.envoyproxy.io/latest/contributions/contributing/#fixing-dco
image

In this contributing page, the squash link: https://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html broken:
image

Seems the site is down or domain problem.

Shell we replace this link to another one? like: https://www.git-tower.com/learn/git/faq/git-squash

Please provide some suggestions, I can fix it.
@wilsonwu wilsonwu mentioned this issue Mar 25, 2024
Merged
@zirain
Copy link
Member

zirain commented Mar 25, 2024

The target is unstable, should replace it with another address.

@zirain zirain added documentation Improvements or additions to documentation help wanted Extra attention is needed and removed triage labels Mar 25, 2024
@zirain zirain mentioned this issue Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix squash link zirain/gateway
2 participants
@wilsonwu @zirain