feat: JWT extractFrom headers and params #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardikabs
force-pushed
the
feat/jwt-extractor-from-headers-and-params
branch
2 times, most recently
from
7843a58 to
185cfc2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
==========================================
+ Coverage 64.74% 64.78% +0.03%
==========================================
Files 115 115
Lines 17415 17429 +14
==========================================
+ Hits 11275 11291 +16
+ Misses 5427 5424 -3
- Partials 713 714 +1 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Jan 11, 2024
api/v1alpha1/jwt_types.go
Outdated
| // | ||
| // +optional | ||
| Headers []JWTHeaderExtractor `json:"headers,omitempty"` | ||
|
|
||
| // Cookies represents a list of cookie names to extract the JWT token from. | ||
| // If specified, Envoy will extract the JWT token from the listed cookies and validate each of them. | ||
| // If any cookie is found to be an invalid JWT, a 401 error will be returned. |
There was a problem hiding this comment.
should we move this invalid JWT string to top level JWTExtractor, since its valid for all fields now ?
There was a problem hiding this comment.
that's right, will move it to the top
ardikabs
force-pushed
the
feat/jwt-extractor-from-headers-and-params
branch
from
185cfc2 to
586038d
Compare
|
/retest |
|
it seems the job encountered an error that appears unrelated to the changes. Could you help here @arkodg? |
|
/retest |
seems like a flaky test |
Signed-off-by: Ardika Bagus <[email protected]>
Signed-off-by: Ardika Bagus <[email protected]>
ardikabs
force-pushed
the
feat/jwt-extractor-from-headers-and-params
branch
from
586038d to
68f23ec
Compare
zirain
approved these changes
Jan 16, 2024
|
/retest |
arkodg
approved these changes
Jan 16, 2024
zesiar0
pushed a commit
to zesiar0/gateway
that referenced
this pull request
Jan 22, 2024
* feat: JWT extractFrom headers and params Signed-off-by: Ardika Bagus <[email protected]> * chore: update comment to the top Signed-off-by: Ardika Bagus <[email protected]> --------- Signed-off-by: Ardika Bagus <[email protected]> Co-authored-by: zirain <[email protected]> Signed-off-by: A3bz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add other fields on
extractFromto support JWT extraction from custom headers or params.What this PR does / why we need it:
Which issue(s) this PR fixes:
Closes #2429