Feat: Support configuring externalTrafficPolicy on the envoy service #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timricese
force-pushed
the
externaltrafficpolicy
branch
from
cfd983d to
89c7a53
Compare
Signed-off-by: Tim Rice <[email protected]>
timricese
force-pushed
the
externaltrafficpolicy
branch
from
89c7a53 to
b9f625d
Compare
Signed-off-by: Tim Rice <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
==========================================
+ Coverage 64.65% 64.70% +0.04%
==========================================
Files 115 115
Lines 17364 17367 +3
==========================================
+ Hits 11227 11237 +10
+ Misses 5425 5419 -6
+ Partials 712 711 -1 ☔ View full report in Codecov by Sentry. |
zirain
approved these changes
Jan 12, 2024
zesiar0
pushed a commit
to zesiar0/gateway
that referenced
this pull request
Jan 22, 2024
…nvoyproxy#2432) * Support configuring externalTrafficPolicy on the envoy service Signed-off-by: Tim Rice <[email protected]> * Update some autogenerated things Signed-off-by: Tim Rice <[email protected]> --------- Signed-off-by: Tim Rice <[email protected]> Co-authored-by: Tim Rice <[email protected]> Signed-off-by: A3bz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Adds possibility to configure externalTrafficPolicy on EnvoyProxy Service objects.
What this PR does / why we need it:
Currently there is no way to change the default "Local" externalTrafficPolicy, which is fine for the vast majority of use cases.
In our case, we run bare-metal without any cloud loadbalancer and rely on MetalLB and Cilium with "Cluster" externalTrafficPolicy to provide loadbalancing within the cluster. Without this, all requests arrive at one single envoy pod.
Which issue(s) this PR fixes: