Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ImagePullSecrets to PodSpec #2337

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

shahar-h
Copy link
Contributor

What this PR does / why we need it:
Add ImagePullSecrets to PodSpec in order to support pulling EnvoyProxy and RateLimit images from private registries.
Use cases:

  • Custom images
  • Pulling images from a private mirror

Which issue(s) this PR fixes: N/A

@shahar-h shahar-h requested a review from a team as a code owner December 21, 2023 12:52
@zirain
Copy link
Member

zirain commented Dec 21, 2023

I think we can learn from istio project, introduce K8SObjectOverlay, no need to add all the fields one by one.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7d411c) 64.55% compared to head (2aa5929) 64.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2337      +/-   ##
==========================================
- Coverage   64.55%   64.55%   -0.01%     
==========================================
  Files         112      112              
  Lines       16072    16074       +2     
==========================================
  Hits        10376    10376              
- Misses       5043     5045       +2     
  Partials      653      653              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Contributor

arkodg commented Dec 21, 2023

@zirain the UX for #2337 (comment) is not great.
I do agree we need some generic way to patch k8s fields we dont have native support for

Pulling Envoy and RateLimit from air gapped & private registries is a common use case imo

@zirain
Copy link
Member

zirain commented Dec 22, 2023

@zirain the UX for #2337 (comment) is not great. I do agree we need some generic way to patch k8s fields we dont have native support for

Pulling Envoy and RateLimit from air gapped & private registries is a common use case imo

it's hard to say which one is common or not.

@arkodg arkodg requested review from a team and qicz December 22, 2023 21:05
@zirain zirain merged commit a06377d into envoyproxy:main Dec 23, 2023
18 checks passed
@shahar-h shahar-h deleted the ep-pull-secret branch December 23, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants