chore: relax https for jwks #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
http-jwks
branch
from
fac185f to
0b00588
Compare
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
http-jwks
branch
from
0b00588 to
fc36b2b
Compare
arkodg
reviewed
Dec 20, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2328 +/- ##
==========================================
+ Coverage 64.71% 64.73% +0.01%
==========================================
Files 113 113
Lines 16557 16565 +8
==========================================
+ Hits 10715 10723 +8
+ Misses 5168 5167 -1
- Partials 674 675 +1 ☔ View full report in Codecov by Sentry. |
zirain
previously approved these changes
Dec 21, 2023
|
/retest |
ardikabs
reviewed
Dec 21, 2023
Signed-off-by: huabing zhao <[email protected]>
ardikabs
reviewed
Dec 21, 2023
Signed-off-by: huabing zhao <[email protected]>
ardikabs
approved these changes
Dec 21, 2023
arkodg
reviewed
Dec 21, 2023
internal/xds/translator/testdata/in/xds-ir/jwt-multi-route-multi-provider.yaml
Outdated
Show resolved
Hide resolved
ardikabs
reviewed
Dec 22, 2023
internal/xds/translator/testdata/in/xds-ir/jwt-multi-route-multi-provider.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
http-jwks
branch
from
5979f5e to
e62546f
Compare
arkodg
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes https scheme restriction for JWKS.
Related: #2327