-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support mergeGateways in EnvoyPatchPolicy #2320
feat: support mergeGateways in EnvoyPatchPolicy #2320
Conversation
🚀 Thank you for contributing to the Envoy Gateway project! 🚀 Before merging, please ensure to follow the process below:
NOTE: Once your PR is under review, please do not rebase and force push it. Otherwise, it will force your reviewers to review the PR from scratch rather than simply look at your latest changes. What's more, you can help expedite the processing of your PR by
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
==========================================
+ Coverage 64.72% 64.73% +0.01%
==========================================
Files 113 113
Lines 16442 16445 +3
==========================================
+ Hits 10642 10646 +4
+ Misses 5130 5129 -1
Partials 670 670 ☔ View full report in Codecov by Sentry. |
@cnvergence this does make sense, can you please expand on the WHY in the PR description ? you will also need to update the validation logic
KindGatewayClass when mergeGateways is true
this feature will also require some additional docs to explain this to the end user |
@arkodg right, I will add this to the GatewayClass level |
Signed-off-by: Karol Szwaj <[email protected]>
45cf433
to
5daefc1
Compare
nvm, it works as expected |
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
/retest |
What type of PR is this?
feat: support mergeGateways in EnvoyPatchPolicy
What this PR does / why we need it:
Support EnvoyPatchPolicy when MergeGateways is enabled and make sure that it targets GatewayClass instead Gateway. As when mergeGateways is enabled, there will be one Envoy deployment for all Gateways in the cluster.
Which issue(s) this PR fixes:
Fixes #2308