-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hostNetwork DNSPolicy support #2309
Conversation
🚀 Thank you for contributing to the Envoy Gateway project! 🚀 Before merging, please ensure to follow the process below:
NOTE: Once your PR is under review, please do not rebase and force push it. Otherwise, it will force your reviewers to review the PR from scratch rather than simply look at your latest changes. What's more, you can help expedite the processing of your PR by
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz fix the CI and make sure it is backport compatible.
internal/gatewayapi/listener.go
Outdated
containerPort := servicePortToContainerPort(servicePort.port) | ||
|
||
containerPort := servicePort.port | ||
if !(resources.EnvoyProxy != nil && resources.EnvoyProxy.Spec.Provider != nil && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just out of curiosity, is there any better way to improve this looong hideous nested nil check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refer to https://github.com/envoyproxy/gateway/blob/main/api/v1alpha1/envoygateway_helpers.go#L80
make it as a common helper to use
hi @zzjin, you can try |
we shouldnt be changing the container port logic, all clients should access the gateway via the service |
@arkodg Any better solutions for using EG in such scenarios:
In this scenario, EG is more like a real loadbalancer, it should be a common request. |
ee28e61
to
a20f05c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
==========================================
+ Coverage 64.67% 64.73% +0.06%
==========================================
Files 114 114
Lines 16618 16633 +15
==========================================
+ Hits 10747 10767 +20
+ Misses 5193 5188 -5
Partials 678 678 ☔ View full report in Codecov by Sentry. |
@Xunzhuo you can route to the service port (80/443) via External IP |
@arkodg Can you elaborate it ? |
|
Correct ... @arkodg I think I missed this, thanks for pointing out. |
And add support listen port under 1024 (like 443). Signed-off-by: zzjin <[email protected]>
Signed-off-by: zzjin <[email protected]>
d2fb176
to
e4e662c
Compare
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
close via #2374 |
And add support listen port under 1024 (like 443).
What type of PR is this?
fix: fix new introduced
hostNetwork
cannot speak to xds bug.May fix: #2310