Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null pointer when CORS maxAge is not specified #2132

Closed
zhaohuabing opened this issue Oct 31, 2023 · 1 comment · Fixed by #2133
Closed

Null pointer when CORS maxAge is not specified #2132

zhaohuabing opened this issue Oct 31, 2023 · 1 comment · Fixed by #2133
Labels
kind/bug Something isn't working

Comments

@zhaohuabing
Copy link
Member

goroutine 125 [running]:
github.com/envoyproxy/gateway/internal/xds/translator.patchRouteWithCORSConfig(0xc0001c7680, 0xc00037e780)
/home/ubuntu/gateway/internal/xds/translator/cors.go:129 +0x5a7
github.com/envoyproxy/gateway/internal/xds/translator.patchRouteWithFilters(0xc0001c7680, 0x0?)
/home/ubuntu/gateway/internal/xds/translator/httpfilters.go:133 +0x65
github.com/envoyproxy/gateway/internal/xds/translator.buildXdsRoute(0xc00037e780)
/home/ubuntu/gateway/internal/xds/translator/route.go:80 +0x1085
github.com/envoyproxy/gateway/internal/xds/translator.(*Translator).processHTTPListenerXdsTranslation(0xc000e73d80, 0xc001226d60, {0xc0006c2618, 0x1, 0x0?}, 0x0?, 0x2948508?, 0x0)
/home/ubuntu/gateway/internal/xds/translator/translator.go:203 +0xb2c
github.com/envoyproxy/gateway/internal/xds/translator.(*Translator).Translate(0xc000e73d80, 0xc0009c6f80)
/home/ubuntu/gateway/internal/xds/translator/translator.go:67 +0x70
github.com/envoyproxy/gateway/internal/xds/translator/runner.(*Runner).subscribeAndTranslate.func1({{0xc000f18cc0?, 0x0?}, 0x4d?, 0xc0009c6f80?}, 0x0?)
/home/ubuntu/gateway/internal/xds/translator/runner/runner.go:80 +0x265
github.com/envoyproxy/gateway/internal/message.HandleSubscription[...]({{0x25efe06, 0x2945910?}, {0x25e294d?, 0x0?}}, 0xc00073ac60?, 0xc000e73f98)
/home/ubuntu/gateway/internal/message/watchutil.go:76 +0x47d
github.com/envoyproxy/gateway/internal/xds/translator/runner.(*Runner).subscribeAndTranslate(0xc000b36100, {0x2945910?, 0xc000710cd0?})
/home/ubuntu/gateway/internal/xds/translator/runner/runner.go:52 +0x8d
created by github.com/envoyproxy/gateway/internal/xds/translator/runner.(*Runner).Start
/home/ubuntu/gateway/internal/xds/translator/runner/runner.go:45 +0x272

@zirain
Copy link
Member

zirain commented Oct 31, 2023

need CEL validation for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants