Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Publishing Strategy #17

Closed
danehans opened this issue Apr 23, 2022 · 19 comments
Closed

Docs Publishing Strategy #17

danehans opened this issue Apr 23, 2022 · 19 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed kind/question Further information is requested priority/low Label used to express the "low" priority level
Milestone

Comments

@danehans
Copy link
Contributor

Should Envoy Gateway's documentation be separate from Envoy's official docs or integrate with https://github.com/envoyproxy/envoy-website

@danehans danehans added documentation Improvements or additions to documentation kind/question Further information is requested labels Apr 23, 2022
@mattklein123
Copy link
Member

cc @phlax. I think it would be fine to integrate this into the main site eventually but I would discuss with Ryan. It needs some thinking about flow and placement.

@phlax
Copy link
Member

phlax commented Apr 24, 2022

i think we can start building here, and then integrate once we are ready to do so

using sphinx/rst, we can link between docs sites so it should be fairly straightforward to start linking to stuff in the main site and then merge

i guess the first step is getting some ci up and running so that we have something to start dropping docs into

i guess the main question re merging is whether they will (always) be released together - if not it might be better to just host on the envoy website but with a different path - eg /docs/envoy-gateway/latest etc

@danehans
Copy link
Contributor Author

@phlax thanks for all the great feedback. I prefer that the gateway project syncs releases with Envoy. I will discuss this with the community and update this issue accordingly.

xref: #15

@danehans
Copy link
Contributor Author

i guess the main question re merging is whether they will (always) be released together - if not it might be better to just host on the envoy website but with a different path - eg /docs/envoy-gateway/latest etc

Initial feedback during this week's community meeting is that Gateway will not be released with Envoy.

cc: @youngnick @LukeShu

@danehans danehans added this to the v0 Release milestone Apr 29, 2022
@arkodg
Copy link
Contributor

arkodg commented May 4, 2022

trying to summarize this discussion regarding docs, please correct me if im wrong

@mattklein123
Copy link
Member

cc @phlax on ^. I think we have moved away from pushing to envoy-website on every change. I would look at how we do it in Envoy now and model it on that.

@phlax
Copy link
Member

phlax commented May 6, 2022

so an explanation of how docs are/were built in Envoy

what we did

  • PRs build/test html generation
  • commits to main - pushed built docs to "latest" on website repo
  • releases - pushed built docs to version on website repo

the problems

altho very litte changed in the docs from commit to commit - the commit hash did and this led to a diff with 1000s of changes on every main commit to the repo -> website-repo

over time the website repo became pretty much unusable - it was huge, and cloning/fetching was prone to failing

eventually i stripped out all the hash/main commits and removed the latest docs from the repo

what we do now

  • PRs - build/test html in CI and publish to (gcloud) ci-local storage
  • commits to main - publish rst to (gcloud) ci-local storage and trigger netlify, which in turns fetches the rst and builds the html from that
  • release commits - publish built html

this has made the website alot easier to work with

the repo is still pretty large as there are a lot of historical versions, so we are currently looking at the possibility of moving some of these to a separate docs archive repo

@arkodg
Copy link
Contributor

arkodg commented May 6, 2022

thanks for sharing the details @phlax !
so my takeaway is - Envoy Gateway will need a CI workflow similar to what Envoy has
when it wants to publish html content, and should ensure it publishes only during a tagged release / or merge to main( for latest) to reduce size of the website repo

Also based on #50 it looks like Envoy Gateway will generate its html using Kubebuilder docs .

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as completed Jul 8, 2022
@danehans danehans reopened this Aug 3, 2022
@danehans danehans added the help wanted Extra attention is needed label Aug 3, 2022
@github-actions github-actions bot removed the stale label Aug 3, 2022
@danehans danehans assigned danehans and unassigned mattklein123 and danehans Aug 4, 2022
@kflynn
Copy link
Contributor

kflynn commented Aug 9, 2022

I'll take this on, although it seems not possible to assign me right now. 😂

@danehans
Copy link
Contributor Author

danehans commented Aug 9, 2022

@mattklein123 @phlax @lizan I'm unable to assign @kflynn to the issue. Can someone advise?

@mattklein123
Copy link
Member

I added explicit read access for the assignable team. I think that fixed it. Assigned.

@kflynn
Copy link
Contributor

kflynn commented Aug 16, 2022

Thanks @mattklein123! #203 is a bare-bones first cut here.

@danehans
Copy link
Contributor Author

xref

@danehans danehans mentioned this issue Sep 6, 2022
@danehans danehans modified the milestones: 0.2.0, 0.3.0-rc.1 Oct 6, 2022
@kflynn
Copy link
Contributor

kflynn commented Oct 6, 2022

Summary of the current state of the world: we're using Sphinx to generate HTML from RST docs, and (for the moment) we're using GitHub Actions to publish said HTML to GitHub Pages (cf https://envoyproxy.github.io/gateway/).

@phlax Shall we just submit an Envoy PR to link out to the GitHub Pages version for now? Otherwise, we still need help getting everything published to GCS and hooked up with the Envoy docs...

@phlax
Copy link
Member

phlax commented Oct 6, 2022

i would say lets link it in initially - not sure exactly how/where - but i think that will be easiest

@danehans danehans added the priority/low Label used to express the "low" priority level label Nov 8, 2022
@arkodg
Copy link
Contributor

arkodg commented Jan 6, 2023

@danehans @kflynn are we keeping this issue open to track eventually linking https://gateway.envoyproxy.io/v0.2.0/ to https://www.envoyproxy.io/docs ?

@danehans
Copy link
Contributor Author

danehans commented Jan 7, 2023

Let's keep our current strategy of using GH Pages to publish EG docs. If anyone disagrees, feel free to reopen.

@danehans danehans closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed kind/question Further information is requested priority/low Label used to express the "low" priority level
Projects
None yet
Development

No branches or pull requests

5 participants